Repository navigation
pressing enter on advanced search should trigger search - #99
Merged
Merged
Conversation
Updated core version requirement to support only Drupal 10 and 11.
joecorall
self-requested a review
August 19, 2026 17:10
joecorall
reviewed
Sep 9, 2026
joecorall
approved these changes
Sep 9, 2026
joecorall
left a comment
joecorall
left a comment
Member
There was a problem hiding this comment.
LGTM with the one nit I commented on
Co-authored-by: Joe Corall <joe@libops.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Drupal 11 added the ability to use type="button" for forms instead of type="submit" so this changes the +, -, and reset buttons to be type="button" which makes the search button the one that is triggered when you press enter. Previously, pressing enter would trigger the + button.
This also removes the javascript piece that overrides the enter key, because it caused enter to trigger the first button instead of the first submit.
On Drupal 10, the buttons should still be rendered as type="submit". In testing this, it seems like without the javascript piece, pressing enter does nothing, instead of triggering the + button as it did before this change. I think this is fine, given where we are in the Drupal 10 lifecycle, but we could probably try to find a solution that works for 10 as well if there was a desire.
On Drupal 11, pressing enter should submit the form.
I also dropped support for Drupal 8 & 9 since they are both EOL
How should this be tested?
Documentation Status
N/A
Additional Notes:
N/A
Interested parties
@Islandora/committers