[Fix] 포트원 결제 orderId 길이 제한 대응 - #239
Conversation
- 결제 준비 시 생성하는 orderId에서 UUID 하이픈을 제거해 40자 이하로 생성 - Toss/PortOne 결제 준비가 동일한 orderId 생성 로직을 사용하도록 정리 - 결제 준비 응답의 orderId 길이 제한 테스트 추가
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough결제 준비 시 Toss Pay와 PortOne이 Changes결제 주문 ID 표준화
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/test/java/com/jobdri/jobdri_api/domain/payment/service/PaymentServiceTest.java`:
- Line 108: Update the assertions in both payment flows, including the PortOne
verification around response.orderId(), to validate the complete order ID
format: the jobdri- prefix followed by exactly 32 lowercase hexadecimal
characters with no hyphens. Replace the current length-only checks while
preserving the existing response validation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 81a304cb-9c35-4a99-bcf3-7fbe44592e79
📒 Files selected for processing (2)
src/main/java/com/jobdri/jobdri_api/domain/payment/service/PaymentService.javasrc/test/java/com/jobdri/jobdri_api/domain/payment/service/PaymentServiceTest.java
- 결제 준비 응답의 orderId 테스트를 길이 검증에서 전체 포맷 검증으로 변경 - jobdri- prefix와 32자리 소문자 hex 문자열 형식을 Toss/PortOne 결제 흐름에 동일하게 적용
✨ 어떤 이유로 PR를 하셨나요?
📋 세부 내용 - 왜 해당 PR이 필요한지 작업 내용을 자세하게 설명해주세요
📸 작업 화면 스크린샷
🚨 관련 이슈 번호 [#170 ]
Summary by CodeRabbit
개선 사항
jobdri-접두사로 시작하며, UUID 하이픈이 제거되어 최대 40자 이내로 생성됩니다.테스트