Repository navigation
Bump hey-api to 0.99 and override js-yaml - #335
Merged
Merged
Conversation
hey-api 0.99 drops handlebars and lodash from the client build graph and moves defu to 6.1.7. Its schema parser pins js-yaml to 4.2.0, so an override lifts it to 4.3.2. A second override lets the backoffice's ^0.85 peer resolve to 0.99 without moving @umbraco-cms/backoffice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Jumoo/jumoo-context#135.
What changes
The backoffice client's dev dependencies only. No .NET or Umbraco package changes.
@hey-api/openapi-tsgoes from ^0.85.0 to ^0.99.0. This removeshandlebarsandlodashfrom the graph, anddefumoves to 6.1.7 through hey-api's newc12.@hey-api/json-schema-ref-parser@1.4.4pinsjs-yamlto exactly 4.2.0, which is still vulnerable. An override lifts it to 4.3.2, the same as LinkedPages and PowerToys.@umbraco-cms/backoffice17.2.1 lists@hey-api/openapi-ts@^0.85.0as a peer, sonpm cifails on 0.99 with ERESOLVE. A second override ("@hey-api/openapi-ts": "$@hey-api/openapi-ts") resolves that peer to the root version.@umbraco-cms/backofficestays at 17.2.1.src/apiisn't regenerated, because generating it needs a running site. The generated code doesn't import hey-api at runtime. I ranscripts/generate-openapi.js'screateClientoptions against a small test spec on 0.99, and it still emits theMigrationsServiceclass.Alerts this should clear
handlebars(#28 to #36, #88 to #90),js-yaml(#70, #73, #79, #87),defu(#39),lodash(#43, #44) and hey-api's own #69. Alerts can take a few hours to close after merge.Left alone
These come in only through
@umbraco-cms/backoffice, so they are dismissed rather than bumped:markdown-itandlinkify-it:@umbraco-cms/backoffice>@tiptap/pm>prosemirror-markdown>markdown-it(>linkify-it)prosemirror-view:@umbraco-cms/backoffice>@tiptap/pmws:@umbraco-cms/backoffice>@microsoft/signalrdompurify:@umbraco-cms/backoffice(and >monaco-editor)Testing
npm cifrom a cleannode_modules: exit 0npm run build(tsc and vite): exit 0dotnet build src/uSync.Migrations.slnx -c Release: exit 0, 0 errorsnpm auditnow lists only packages inherited from the backoffice.🤖 Generated with Claude Code