Repository navigation
Conversation
Block List only allows element types, but Nested Content would use any doc type, so a migrated Block List could point at doc types it can't use. The Nested Content config migrator now records each ncAlias in the migrations tracking table (data types import before content types). A uSyncImportingItemNotification handler sets IsElement in the content type XML as it comes in. Tracking is persistent, so re-importing the legacy file doesn't flip it back. Doc types allowed at root, or with existing content nodes, are left alone with a warning, as they are being used as pages too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Not needed. A dry run on a fresh v17 site (v17/main, no change) migrated Nested Content to Block List fine with a non-element doc type in the blocks: config and content convert, Umbraco saves both. The content page shows an error in the backoffice until the doc type is set to 'Is an Element Type', and setting it afterwards fixes it. So this is a post-migration step for the user, not worth a handler on every imported node. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block List only allows element types. Nested Content would use any doc type, so after migration a Block List could point at doc types it can't use, and the customer would have to flip "Is an Element Type" by hand on each one.
What changed
NestedContentConfigurationMigratorrecords eachncAliasin the migrations tracking table (keyNestedContentElement:{alias}). Data types import before content types, so the record is there in time.NestedContentElementTypeImportingHandler(onuSyncImportingItemNotification) setsInfo/IsElementto true in the content type XML before it's deserialized, when the alias is tracked.Not covered here
On a fresh site, a single import still gives Nested Content data types an empty Block List: the config migrator runs before the doc types exist, so it can't resolve
ncAliasto a key. The migrate tab avoids this because it imports settings, then All. A plain one-off import needs a second import. Worth a separate fix.Testing
Builds. Not run end to end. The test site has no Nested Content uSync files, so it needs a v13 export with Nested Content to verify.
🤖 Generated with Claude Code