Skip to content

Stale uppercase GOLD registration in kg_model_review.py and custom_curies.yaml after #1051 unified on gold: #1065

Description

@realmarcin

Found by the adversarial review of the uncommitted #1051 fix, upheld 3/3. Registration/documentation drift, not a data defect.

After #1051, constants.py:242 is GOLD_PREFIX = "gold:" and nothing should emit GOLD:. But:

  • .claude/skills/kg-model-review/kg_model_review.py:245-249 still lists "GOLD" in STANDARD_PREFIXES, with a comment saying MicrobeDecoder emits it; there is no lowercase gold entry. The validator would therefore accept a regression back to the split namespace.
  • kg_microbe/transform_utils/custom_curies.yaml:18-19 still names uppercase GOLD as the registered crosswalk form (lowercase is registered only at line 1060, gold: {}).

Other guards still catch a regression (test_crosswalk_targets_are_not_stubbed; invariants now report uppercase GOLD stubs as unexpected), so this is drift rather than a live gap.

Acceptance: both registries name gold and not GOLD, and their comments match the code.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions