Clear the last 25 mapping validation errors - #65
Merged
KrishnaTO merged 1 commit intoAug 16, 2026
Conversation
Takes the audit to 0 errors, 17 warnings. Removed 9 null cross-reference rows from each export. Four were flagged-wrong rows recording a curator rejecting nothing; five were confirmations of a mapping to an identifier that was never written. They are removed rather than repaired, because supplying the real id is a curation judgment and recording NoTermFound instead would assert the vocabulary has no term, which is false in at least one case. The nine pairs need re-review. That case is worth naming: #49 supplied mesh:C580192 for ARI:0001105 by review suggestion on 2026-08-03, and a mesh:null row dated 2026-08-07 has since replaced it. A hand-corrected value was overwritten by the same defect four days later. Also fixes MONDO:MONDO:0014523 in both exports, restores the leading zeros on DOID:0111157 in the equivalencies export to match the ontology and clear the last cross-file drift, de-prefixes two ARI_MONDO values that were stored as MONDO:nnnnnnn where the other 55 are bare digits, and drops the ICD-10 range I00-I02 from Rheumatic fever, which already records I00 as a single code alongside it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #62 (which is stacked on #61). Review order is #61 → #62 → this. GitHub retargets automatically as each merges.
With this, the audit goes to 0 errors, 17 warnings.
1. Nine
nullcross-reference rows removed from each exportFour were flagged-wrong rows — a curator recorded rejecting nothing at all. Five were confirmations: a mapping asserted to exist against an identifier that was never written.
They are removed rather than repaired. Supplying the real id is a curation judgment I should not make on a curator's behalf, and recording
NoTermFoundinstead would assert the vocabulary has no term for the disease — which is demonstrably false in at least one case below.These nine pairs need re-review:
ncit:C37871)The ARI:0001105 case is worth a look
#49 supplied
mesh:C580192for that disease by review suggestion on 2026-08-03. Amesh:nullrow dated 2026-08-07 has since replaced it — the corrected value is gone from the file entirely.A hand-fixed mapping was overwritten by the same defect four days later. That is precisely the regression the check in #63 exists to stop, and it is the strongest argument for landing that PR.
2. Four mechanical fixes
Each was settled by checking the ontology rather than by judgement:
MONDO:MONDO:0014523→MONDO:0014523in both exports. The prefix was concatenated onto a value that already carried it.DOID:111157→DOID:0111157in the equivalencies export — the last cross-file drift. The ontology stores0111157for ARI:0001011, so the leading zeros were lost on the equivalencies side, not invented on the SSSOM side.ARI_MONDOvalues de-prefixed in the ontology: ARI:0001080 and ARI:0002 storedMONDO:0005147andMONDO:0011027where the other 55 MONDO values are bare digits.I00-I02removed from Rheumatic fever (ARI:0001182). Nothing is lost — the disease already recordsI00as a single code alongside it, and a range is not an exact match.Verification
The full diff is 5 insertions and 24 deletions: 3 rewritten rows, 18 deleted rows, 3 ontology lines. Every ontology change is listed above in full.
The 17 remaining warnings are unchanged and non-blocking — 11 confirmed mappings not stored on their disease, 6 diseases holding a DXCODE with no SNOMED counterpart.
Advances #23 ("Fill all missing values from database xrefs" is what the nine pairs above now need); referenced rather than closed.
🤖 Generated with Claude Code