Repository navigation
Trust the rook formula before brew-smoke reads it - #14
Merged
Merged
Conversation
Homebrew 7.0.11, preinstalled on the macos-15 image, refuses to load a formula from a third-party tap until it is trusted, so the 0.1.17 smoke failed at `brew deps` with "Refusing to load formula lambdatest/rook/rook from untrusted tap" (run 41035793238). `brew install lambdatest/rook/rook` trusts the formula it names, as it does for users, but `brew deps` runs first. The Linux job passed only because setup-homebrew trusted the tap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.1.17 brew-smoke (run 41035793238) failed on
macos-armbefore installing anything:The macos-15 image now ships Homebrew 7.0.11, which won't load a formula from a third-party tap until it is trusted.
brew install lambdatest/rook/rooktrusts the formula it names (the Linux log showsTrusted formula lambdatest/rook/rook), but the smoke runsbrew depsfirst. The Linux job passed only becausesetup-homebrewhad already trusted the tap.This adds
brew trust --formula lambdatest/rook/rookafterbrew tapin both jobs. Users are unaffected: the README and the install docs use the fully qualified name, and the docs already saybrew install rookcan be rejected as untrusted. The 0.1.17 bottles (arm64_sequoia,x86_64_linux) are published and in the formula.After merge:
gh workflow run brew-smoke.yml -f expected-version=0.1.17, since a re-run of the failed run would reuse the old workflow file.🤖 Generated with Claude Code