feat(studio): add Phoenix state scenarios

[92Infinitus92]

Adds Phoenix Eternal scenario support to Studio:

• Phoenix state preset with live market selection
• collateral stress, direct mark shock, and spot/perp divergence
  flows
• AI chip for two-stage liquidation cascade scenarios
• Phoenix protocol icon and scenario-editor support
• constrained, scrollable market selection
• scenario API integration and validation feedback

Verification

• 298 Studio tests
• TypeScript typecheck
• Studio lint
• manual validation of collateral, mark-price, reference-
  divergence, and two-stage cascade scenarios

Stacking

This PR is stacked on feat/pump-protocol-ui.

Once the Pump UI PR is merged into develop, this branch will be rebased and retargeted to develop.

Greptile Summary

Adds Phoenix Eternal state-scenario support to Studio.

• Adds live Phoenix market discovery and collateral, mark-price, and reference-price scenario creation.
• Integrates Phoenix templates into the scenario editor while preserving exact integer values.
• Adds the Phoenix preset, protocol icon, AI cascade prompt, constrained listbox behavior, validation feedback, and tests.

Confidence Score: 5/5

The PR appears safe to merge once its explicitly acknowledged coupled backend dependency is landed.

No blocking failure remains within the eligible follow-up-review findings.

Important Files Changed

Filename	Overview
apps/studio/src/lib/scenarios-api.ts	Adds Phoenix market discovery and scenario-creation helpers using MCP and the generic scenario API.
apps/studio/src/components/svm/phoenix-state-dialog.tsx	Adds a validated dialog for collateral, direct-mark, and reference-divergence scenarios.
apps/studio/src/components/svm/scenario-editor.tsx	Adds Phoenix templates, dynamic market options, exact integer editing, and account preservation.
packages/ui/src/catalyst/listbox.tsx	Adds constrained, scrollable listbox behavior used by live market selection.

Sequence Diagram

sequenceDiagram
  actor User
  participant Dialog as Phoenix State Dialog
  participant API as Studio Scenario API
  participant MCP as Surfpool MCP
  User->>Dialog: Select state goal and enter values
  alt Collateral stress
    Dialog->>MCP: create_phoenix_collateral_scenario
    MCP-->>Dialog: Scenario URL / ID
  else Market-based scenario
    Dialog->>MCP: list_phoenix_markets
    MCP-->>Dialog: Live market symbols
    Dialog->>API: Load template and create scenario
    API-->>Dialog: Scenario ID
  end
  Dialog-->>User: Open created scenario

Loading

_{Reviews (14): Last reviewed commit: "fix(phoenix): render explicit scenario i..." | Re-trigger Greptile}

[github-actions]

• P1 — Phoenix workflows call nonexistent backend routes (scenarios-api.ts:69): The coupled Surfpool router does not register phoenix-markets, phoenix-collateral, phoenix-direct-mark, or phoenix-reference-prices. All newly exposed Phoenix flows therefore fail with 404s. Add the backend routes before exposing these controls, or use existing supported endpoints.

• P2 — Listboxes no longer avoid viewport boundaries (listbox.tsx:83): Replacing Headless UI’s anchored positioning with absolute top-full removes automatic flipping and available-height calculation. Listboxes near the bottom of a dialog or viewport can render partially off-screen. Retain anchored positioning and constrain its calculated available height.

[github-actions]

• High: scenarios-api.ts:68 calls four new Phoenix endpoints, but this PR provides no corresponding server routes. Market discovery and all creation flows will return 404 unless the backend changes land first. Add/stack the required server implementation or gate the UI until available.

[92Infinitus92]

@greptileai

[92Infinitus92]

• High: scenarios-api.ts:68 calls four new Phoenix endpoints, but this PR provides no corresponding server routes. Market discovery and all creation flows will return 404 unless the backend changes land first. Add/stack the required server implementation or gate the UI until available.

could you please check this PR here LimeChain/surfpool#9 as i believe it resolves the above mentioned reported problem

[github-actions]

• P1 – Invalid Phoenix markets can be saved as scenarios. phoenix-state-dialog.tsx:68 accepts any non-empty symbol, while scenarios-api.ts:135 posts directly to the generic scenario endpoint. This bypasses live market discovery/validation, so typos like BTCC can create unusable scenarios that fail only when applied. Restore market discovery or validate through the Phoenix tool/backend before creation.

[92Infinitus92]

@greptileai

[github-actions]

Found one issue:

• scenarios-api.ts:237: new URL(payload.url) rejects relative scenario URLs such as /scenarios?id=..., although these are valid MCP responses. Resolve against studioUrl, e.g. new URL(payload.url, studioUrl), and add a relative-URL test.

[github-actions]

• scenarios-bento.types.ts:95: The cascade prompt names a trader and market but instructs create_scenario values containing only quote_lot_collateral and target_ticks. Explicitly include the trader and symbol bindings in their respective overrides; otherwise the generated scenario may target unresolved/default accounts.

• phoenix-state-dialog.tsx:142: Clear symbolOptions before each market lookup. If a previous lookup succeeded and a later one fails, the old catalog remains and incorrectly validates/rejects symbols for the new Studio instance.

[github-actions]

• [P3] Preserve field spacing around listboxes — listbox.tsx:23: The new wrapper leaves data-slot="control" on the nested button. Catalyst’s Field spacing selectors require the control to be a direct child, so labels, descriptions, and errors lose their margins when used with this component. Add data-slot="control" to the wrapper or remove the unnecessary wrapper.

Tests weren’t run because dependencies aren’t installed. Backend compatibility could not be verified from this repository.

[github-actions]

• [P2] Editing loses the live PerpAssetMap address. scenarios-api.ts:179 creates overrides against the discovered map, but updateActionInSlot replaces their account with action.template.address. When the live map differs from the template, clicking Update Action silently retargets the scenario. Preserve the saved account when editing, and test creation → editing with different live/template addresses.

Tests were not run because dependencies are not installed.

[github-actions]

• [P2] Newly added editor actions still target the static market account. scenario-editor.tsx:130 fetches symbols but discards the live perpAssetMap. “Add Action” consequently saves template.address. On forks with a migrated map, these actions target the wrong account. Retain the catalog address and use it for new Phoenix market actions.

• [P3] Listbox wrapper breaks Field spacing. listbox.tsx:23 moves data-slot="control" beneath an unmarked wrapper, breaking Field’s direct-child spacing selectors. Put data-slot="control" on the wrapper.

Tests were not run; dependencies are unavailable in this checkout.

[github-actions]

• [P2] Wait for live market discovery before saving new actions — scenario-editor.tsx:135. Catalog loading neither clears previous dynamicOptions nor disables “Add Action.” Saving while discovery is pending can persist a stale PerpAssetMap or the template’s fixed address. Closing the panel then cancels the discovery update, leaving that incorrect address saved. Track loading per Studio URL/source and require successful address resolution before adding a Phoenix market action.

Review limited to the specified changes. Tests were not run.

[github-actions]

• [P2] Failed market discovery still permits saving a stale account address. In override-account.ts:16, missing catalog data silently falls back to the template address. Since discovery errors return an empty catalog and re-enable Add Action, a new Phoenix action can target the old PerpAssetMap after migration. Require successful address discovery for new dynamic actions and offer retry; saved actions can retain their existing address.

Could not run the focused tests because pnpm is unavailable.

[github-actions]

• [P2] Prevent saving Phoenix actions without a market. In scenario-editor.tsx:129, market discovery runs independently of account loading, but “Add to Selected Slot” only checks whether a slot and action are selected. Users can save while markets are loading—or after discovery fails—with no symbol, producing an invalid Phoenix override. Disable adding until a required market is selected, and show discovery failures with a retry option. Preserve the ability to edit saved actions whose symbols are already present.