feat(scenarios): add reusable raw-layout overrides - #15
Open
bakasura980 wants to merge 2 commits into
Open
bakasura980 wants to merge 2 commits into
bakasura980 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
The PR adds reusable byte-level account override layouts for programs without an IDL and routes them through scenario materialization.
Confidence Score: 4/5
The PR is not yet safe to merge because Studio cannot construct overrides from the newly exposed IDL-less raw-layout templates.
Raw-layout templates are returned with no IDL, but the coupled Studio editor still exits before account loading and exposes no raw-layout editing path, leaving the feature unusable through that supported client.
Files Needing Attention: crates/types/src/scenarios.rs and the coupled Studio scenario editor
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR T[Raw-layout template] --> V[Validate layout and properties] V --> R[Register template without IDL] R --> S[Schedule scenario override] S --> G[Check account size and magic] G --> E[Encode supplied values] E --> W[Write bytes at configured offsets] W --> A[Update local SVM account]Reviews (2): Last reviewed commit: "fix(scenarios): validate raw-layout temp..." | Re-trigger Greptile
Context used: