Repository navigation
fix: preserve Dockle environment for consumer dependencies - #17
Merged
ReenigneArcher merged 3 commits intoSep 20, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
=======================================
Coverage 92.81% 92.81%
=======================================
Files 11 11
Lines 1866 1866
Branches 51 51
=======================================
Hits 1732 1732
Misses 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
|
|
ReenigneArcher
marked this pull request as ready for review
September 20, 2026 13:29
ReenigneArcher
deleted the
codex/readthedocs-preserve-dockle-environment
branch
September 20, 2026 13:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Preserve Dockle's virtual environment when installing a consumer project's locked
docsdependency group.The previous
uv syncapproach could replace the environment when the consumer'srequires-pythonconstraint selected a different interpreter. Themerr-jellyfin requires Python 3.14 while Dockle's hosted environment uses Python 3.13, so the sync recreatedthird-party/dockle/.venvand removed Dockle before the build ran.The shared build now exports the exact locked
docsgroup to a temporary requirements file and installs it into Dockle's existing interpreter. This keeps the consumer lockfile authoritative without allowing its project-level Python constraint to replace the orchestrator environment.Validated with:
sphinx-csharpsourcepython -m pytest(120 passed, 1 skipped)bash -n readthedocs_build.shScreenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.