Repository navigation
Decode periodic IB markers in the moment of inertia sum - #1992
Closed
sbryngelson wants to merge 3 commits into
Closed
sbryngelson wants to merge 3 commits into
sbryngelson wants to merge 3 commits into
Conversation
s_compute_moment_of_inertia compared raw ib_markers against gbl_patch_id. Cells of a periodic image carry an encoded marker (gbl_id + (num_gbl_ibs+1)*(xp + 3*yp + 9*zp)), so they were dropped from the sum. Decode the marker with s_decode_patch_periodicity, as the other marker loops do, and measure each cell from the centroid of the image it belongs to, as s_compute_ib_forces does. A rank holding no cell of the body divided 0 by 0. Return the same dummy value of 1 used for a non-rotating body instead. Remaining issue: count and the r^2 sum are over this rank's cells only, so a body split across ranks gets a different moment on each rank. The routine is a GPU_ROUTINE called from inside the s_initialize_ibm_module and s_propagate_immersed_boundaries device loops, so an MPI reduction cannot be added here; the sum has to move to host code with an allreduce before those loops. All 61 IBM tests and 12 IB example tests pass against the existing goldens.
Lines of Code
|
Member
Author
|
Closing this for now to bring the number of open PRs from me down to four, so the ones that stay open get real review attention rather than being lost in a queue of 35. No work is lost and nothing needs re-doing. The branch I intend to reopen these in small batches as the open slots free up. Apologies for the notification noise. Opened and closed with Claude Code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s_compute_moment_of_inertia compared raw ib_markers against
gbl_patch_id. Cells of a periodic image carry an encoded marker
(gbl_id + (num_gbl_ibs+1)(xp + 3yp + 9*zp)), so they were dropped
from the sum. Decode the marker with s_decode_patch_periodicity, as
the other marker loops do, and measure each cell from the centroid of
the image it belongs to, as s_compute_ib_forces does.
A rank holding no cell of the body divided 0 by 0. Return the same
dummy value of 1 used for a non-rotating body instead.
Remaining issue: count and the r^2 sum are over this rank's cells
only, so a body split across ranks gets a different moment on each
rank. The routine is a GPU_ROUTINE called from inside the
s_initialize_ibm_module and s_propagate_immersed_boundaries device
loops, so an MPI reduction cannot be added here; the sum has to move
to host code with an allreduce before those loops.
All 61 IBM tests and 12 IB example tests pass against the existing
goldens.