[sbryngelson]

The pre_process and simulation data-output routines declared bc_type as
an explicit-shape dimension(1:num_dims, -1:1) dummy, three columns wide,
while every actual is allocated (1:num_dims, 1:2). The callee could
index past the end of the actual through sequence association.

pre_process forwards bc_type to routines that expect (1:num_dims, 1:2),
so declare it with that shape. The simulation routines never use
bc_type, so drop the argument from s_write_data_files and the serial and
parallel writers.

No change to results; the debug CPU test suite passes unchanged.

[github-actions]

Lines of Code

File	Lines	Diff
src/simulation/m_data_output.fpp	1575	-3

Directory	Lines	Diff
simulation	28500	-3
total	47511	-3

[sbryngelson]

Closing this for now to bring the number of open PRs from me down to four, so the ones that stay open get real review attention rather than being lost in a queue of 35.

No work is lost and nothing needs re-doing. The branch fix/bc-type-dummy-shape remains on the fork at 6d82d2ebfb, this PR's diff and discussion stay here, and the head commit is additionally archived in a local verified bundle. Reopening takes no force-push and no rebase:

gh pr reopen 1996 -R MFlowCode/MFC

I intend to reopen these in small batches as the open slots free up. Apologies for the notification noise.

Opened and closed with Claude Code.