Repository navigation
Fill ib_markers halo cells in post_process - #2011
Closed
sbryngelson wants to merge 3 commits into
Closed
sbryngelson wants to merge 3 commits into
sbryngelson wants to merge 3 commits into
Conversation
The silo ib_markers field includes the ghost layers, but post_process reads only the interior, so the ghosts were 0 and overwrote the neighbor rank's real cells when the files were assembled. Fill them with the existing MPI buffer exchange.
Lines of Code
|
Member
Author
|
Closing this for now to bring the number of open PRs from me down to four, so the ones that stay open get real review attention rather than being lost in a queue of 35. No work is lost and nothing needs re-doing. The branch I intend to reopen these in small batches as the open slots free up. Apologies for the notification noise. Opened and closed with Claude Code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2010
post_process writes
ib_markersincluding its ghost layers, but reads only the interior, so the ghosts were 0. The viz silo assembler let those zeros overwrite the neighbor rank's real cells, showing 2 fluid planes inside the body before each internal rank boundary.Add
s_exchange_ib_markers_halo, which copies the markers into a realscalar_fieldand fills the MPI-boundary ghosts with the existings_mpi_sendrecv_variables_buffers, then returns the ghost-inclusive array thats_save_datawrites. No new exchange code. Physical-boundary ghosts are left as before.Verified on test A2036630 (2D IBM rectangle, 50x40, CPU+MPI, silo output at step 1), solid cells per x column for columns 15-34:
The 2-rank output with this PR is identical to the 1-rank output.
./mfc.sh test --no-mpi --no-gpu -j 24 --only IBMpasses (61 passed, 0 failed), and./mfc.sh precheckpasses. Only post_process output changes; simulation results are unaffected. The 3D multi-rank case from the issue was not re-run.