Use ManimColor opacity in VMobjects along with object's opacity - #4940
Open
UnMolDeQuimica wants to merge 2 commits into
Open
Conversation
Author
|
I am aware of this PR but I do not think it is still relevant or useful after the addition of |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Currently, when using a
ManimColorwith an alpha value, theVMobjectopacity overwrites said value. With these changes the opacity of theManimColoris taken in account.It is done by multiplying the
ManimColor's alpha value with theVMobjectopacity, so it supports existing code and animations.Motivation and Explanation: Why and how do your changes improve the library?
As mentioned, setting the
alphavalue of a ManimColor did not affect the opacity of the resulting VMobject. This sounds, at least, counterintuitive to me. What if I want to use a single color in multiple objects and let the color handle the opacity? Or what if I want a gradient that supports transparent colors?Here's an example of what can be done with these changes:
Here is a video example:
ManimColorWithOpacityChangesScene.mp4
Links to added or changed documentation pages
No documentation changes needed (I think).
Further Information and Comments
All tests pass
Reviewer Checklist