Fix closeable directive for plain text content - #2918
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2918 +/- ##
=======================================
Coverage 71.32% 71.32%
=======================================
Files 133 133
Lines 7234 7234
Branches 1642 1650 +8
=======================================
Hits 5160 5160
Misses 1973 1973
Partials 101 101 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Incogdino
left a comment
There was a problem hiding this comment.
Hi, thank you for the pr! The update works well visually.
Please help to update the snapshot tests by running the updatetest script using npm run updatetest
You can refer to the dev docs here: https://markbind.org/devdocs/devGuide/development/workflow.html#updating-functional-tests
|
Thanks for the review. I ran the requested snapshot update from this branch after It completed successfully for both That passed as well. If you expected a specific functional snapshot to change, could you point me to that case? I do not want to commit generated files that are identical to the current snapshots. |
What is the purpose of this pull request?
Fixes #2662.
Overview of changes:
Anything you'd like to highlight/discuss:
The directive previously iterated over
Element.children, which excludes text nodes. It now useschildNodesso plain text is preserved alongside element children.Testing instructions:
N/A.
Proposed commit message: (wrap lines at 72 characters)
Fix closeable plain text handling
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):