Skip to content

test: run messenger on Vitest - #10869

Open
cryptodev-2s wants to merge 3 commits into
mainfrom
test/vitest-messenger
Open

cryptodev-2s wants to merge 3 commits into
mainfrom
test/vitest-messenger

Conversation

@cryptodev-2s

@cryptodev-2s cryptodev-2s commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Explanation

Moves @metamask/messenger to Vitest.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
    • Not applicable, test only change. Carries the no-changelog label.
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
    • None.

Note

Low Risk
Test-only and config changes with no runtime library behavior changes; main risk is CI or local test workflow regressions.

Overview
Migrates @metamask/messenger from Jest + Tstyche to Vitest as part of the broader Jest→Vitest effort. Production code is unchanged; only test tooling and configs move.

The package drops jest.config.cjs and adds vitest.config.js (shared package base, typecheck enabled, same coverage thresholds as before). package.json scripts now call vitest only—no separate test:types / Tstyche step. Unit tests use vi instead of jest; type tests in Messenger.test-d.ts use @ts-expect-error instead of Tstyche’s expect().type assertions. Build/tsconfig excludes **/*.test-d.ts instead of *.tst.ts, and Jest types are removed from the package tsconfig. @metamask/messenger is removed from the Jest test-runner package map so CI runs it via Vitest.

Reviewed by Cursor Bugbot for commit 1144493. Bugbot is set up for automated code reviews on this repo. Configure here.

@cryptodev-2s
cryptodev-2s requested a review from a team as a code owner October 16, 2026 14:31
@cryptodev-2s
cryptodev-2s deployed to default-branch October 16, 2026 14:32 — with GitHub Actions Active

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3345d9c. Configure here.

Comment thread packages/messenger/src/Messenger.test-d.ts Outdated
@cryptodev-2s
cryptodev-2s marked this pull request as draft October 16, 2026 14:35
@cryptodev-2s
cryptodev-2s marked this pull request as ready for review October 16, 2026 16:58
@cryptodev-2s
cryptodev-2s deployed to default-branch October 16, 2026 16:59 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
default-branch — 11444938 Deployed Oct 16, 2026 by cryptodev-2s via Determine whether this PR is a release PR #5615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant