Repository navigation
test: run utils on Vitest - #10871
Open
cryptodev-2s wants to merge 2 commits into
Open
cryptodev-2s wants to merge 2 commits into
cryptodev-2s wants to merge 2 commits into
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Moves
@metamask/utilsto Vitest.References
Checklist
no-changeloglabel.Note
Low Risk
Test-only and tooling changes; no production runtime code in
@metamask/utilsis altered.Overview
Migrates
@metamask/utilsfrom Jest + tstyche to Vitest for unit tests and built-in typecheck, consolidatingtestscripts and dropping Jest/tstyche config and dependencies.Adds
vitest.config.js(100% coverage thresholds, typecheck on) and removesjest.config.cjs. Test files switch tovi/vitestimports; mocks and spies are updated where Jest patterns do not carry over (@noble/hashesspy mocks,jest-when→ explicit spy +toHaveBeenCalledWith,vi.stubGlobalforError, proxy trap forisPlainObject,it.each%#for non-serializable fixtures). Former*.tst.tstype tests become*.test-d.tsusingexpectTypeOf(as constwhere literals matter).Package
tsconfig.jsongainsskipLibCheckso Vitest typecheck toleratesweb3declarations underexactOptionalPropertyTypes.@metamask/utilsis removed from the repo Jest test-runner map; oxlint suppression entries are trimmed/renamed for the new file names.Reviewed by Cursor Bugbot for commit 4e5140a. Bugbot is set up for automated code reviews on this repo. Configure here.