Repository navigation
test: run network-controller on Vitest - #10873
Open
cryptodev-2s wants to merge 2 commits into
Open
cryptodev-2s wants to merge 2 commits into
cryptodev-2s wants to merge 2 commits into
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Moves
@metamask/network-controllerto Vitest.References
Checklist
no-changeloglabel.Note
Low Risk
Test and tooling migration only; production
network-controllerruntime code is unchanged aside from lint-suppression bookkeeping.Overview
Migrates
@metamask/network-controllerfrom Jest (+ TSTyche) to Vitest as part of the broader test-runner migration.The package drops
jest.config.cjsand Jest-related devDependencies;package.jsonscripts now callvitest, with a mergedvitest.config.jsthat addstests/**/*.test.ts(largeNetworkControllersuites outsidesrc/), enables typecheck for*.test-d.ts(TSTyche →expectTypeOf().toExtend()), and sets Vitest coverage thresholds.Test code is mechanically updated (
jest→vi, fake timers, mocks). Notable fixes beyond rename:waitForPromiseToBeFulfilledAfterRunningAllTimersyields a real macrotask beforevi.runAllTimersAsyncso nock replies settle;onBreakexpectations useHttpError(503)instead of genericError;ignoreRejectionlives intests/vitest/helpers.ts; Jest-onlyjest-whenremoved; jsdom test environment removed (node passes). The package is removed from the Jesttest-runner-package-map.Reviewed by Cursor Bugbot for commit ffac03d. Bugbot is set up for automated code reviews on this repo. Configure here.