Repository navigation
test: run core-ux packages on Vitest - #10952
Merged
Merged
Conversation
cryptodev-2s
force-pushed
the
test/vitest-core-ux
branch
from
October 21, 2026 10:14
712ef6f to
8c38c8d
Compare
cryptodev-2s
marked this pull request as ready for review
October 21, 2026 10:36
cryptodev-2s
force-pushed
the
test/vitest-core-ux
branch
from
October 22, 2026 10:42
8c38c8d to
ab4d3c4
Compare
cryptodev-2s
enabled auto-merge
October 22, 2026 10:44
cryptodev-2s
commented
Oct 22, 2026
NidhiKJha
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Moves
@metamask/announcement-controllerand@metamask/client-utilsto Vitest.References
Checklist
no-changeloglabel.Note
Low Risk
Test-only and tooling changes; production package code is unchanged aside from lint suppressions.
Overview
Migrates
@metamask/announcement-controllerand@metamask/client-utilsfrom Jest to Vitest as part of the core-ux test runner rollout.Each package drops
jest.config.cjsand Jest-related devDependencies/scripts in favor ofvitest.config.ts(merged with the shared package config) andvitestnpm scripts, with prior coverage thresholds preserved.tsconfig.jsonno longer includes Jest types. Tests switch to Vitest globals/APIs (describe/expect/itimports,vi.mock/vi.spyOn/vi.restoreAllMocks, including ESM-stylevi.mock(import(...))for module mocks).test-runner-package-map.cjsremoves both packages fromPACKAGES_ON_JEST, andoxlint-suppressions.jsondrops Jest-config suppressions while updatingclient-utilsmapper test entries forvitest/no-conditional-in-test.Reviewed by Cursor Bugbot for commit a9c4854. Bugbot is set up for automated code reviews on this repo. Configure here.