Skip to content

test: run core-ux packages on Vitest - #10952

Merged
cryptodev-2s merged 2 commits into
mainfrom
test/vitest-core-ux
Oct 22, 2026
Merged

cryptodev-2s merged 2 commits into
mainfrom
test/vitest-core-ux

Conversation

@cryptodev-2s

@cryptodev-2s cryptodev-2s commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Explanation

Moves @metamask/announcement-controller and @metamask/client-utils to Vitest.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
    • Not applicable, test only change. Carries the no-changelog label.
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
    • None.

Note

Low Risk
Test-only and tooling changes; production package code is unchanged aside from lint suppressions.

Overview
Migrates @metamask/announcement-controller and @metamask/client-utils from Jest to Vitest as part of the core-ux test runner rollout.

Each package drops jest.config.cjs and Jest-related devDependencies/scripts in favor of vitest.config.ts (merged with the shared package config) and vitest npm scripts, with prior coverage thresholds preserved. tsconfig.json no longer includes Jest types. Tests switch to Vitest globals/APIs (describe/expect/it imports, vi.mock/vi.spyOn/vi.restoreAllMocks, including ESM-style vi.mock(import(...)) for module mocks).

test-runner-package-map.cjs removes both packages from PACKAGES_ON_JEST, and oxlint-suppressions.json drops Jest-config suppressions while updating client-utils mapper test entries for vitest/no-conditional-in-test.

Reviewed by Cursor Bugbot for commit a9c4854. Bugbot is set up for automated code reviews on this repo. Configure here.

@cryptodev-2s
cryptodev-2s marked this pull request as ready for review October 21, 2026 10:36
@cryptodev-2s
cryptodev-2s requested review from a team as code owners October 21, 2026 10:36
@cryptodev-2s
cryptodev-2s deployed to default-branch October 21, 2026 10:36 — with GitHub Actions Active
@cryptodev-2s cryptodev-2s self-assigned this Oct 21, 2026
Comment thread packages/client-utils/src/formatters/create-formatters.test.ts Outdated
@cryptodev-2s
cryptodev-2s added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit de39279 Oct 22, 2026
370 checks passed
@cryptodev-2s
cryptodev-2s deleted the test/vitest-core-ux branch October 22, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants