Repository navigation
test: run delegation packages on Vitest - #10953
Merged
Merged
Conversation
cryptodev-2s
force-pushed
the
test/vitest-delegation
branch
from
October 21, 2026 11:13
2e04298 to
5dea817
Compare
cryptodev-2s
marked this pull request as ready for review
October 21, 2026 11:31
cryptodev-2s
force-pushed
the
test/vitest-delegation
branch
from
October 21, 2026 11:31
5dea817 to
0267231
Compare
cryptodev-2s
enabled auto-merge
October 21, 2026 11:32
MoMannn
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Moves
@metamask/delegation-controllerand@metamask/gator-permissions-controllerto Vitest.References
Checklist
no-changeloglabel.Note
Low Risk
Test-only and tooling changes; production controller code is unchanged.
Overview
Migrates
@metamask/delegation-controllerand@metamask/gator-permissions-controllerfrom Jest to Vitest, following the same package-level pattern used elsewhere in the repo (sharedvitest.config.packages.js, per-packagevitest.config.tswith prior coverage thresholds).For each package, test scripts and devDependencies switch to Vitest; Jest config and
jestTypeScript types are removed. Test sources are updated mechanically (jest→vi, Vitest imports,vi.mockwith dynamic import in gator-permissions,flushPromisesfromtests/vitest/helpers.js).Repo wiring: both packages are dropped from the Jest runner map in
test-runner-package-map.cjs, andoxlint-suppressions.jsonis adjusted (includingvitest/no-conditional-in-testentries for gator-permissions tests).Reviewed by Cursor Bugbot for commit 0267231. Bugbot is set up for automated code reviews on this repo. Configure here.