Skip to content

test: run delegation packages on Vitest - #10953

Merged
cryptodev-2s merged 2 commits into
mainfrom
test/vitest-delegation
Oct 21, 2026
Merged

cryptodev-2s merged 2 commits into
mainfrom
test/vitest-delegation

Conversation

@cryptodev-2s

@cryptodev-2s cryptodev-2s commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Explanation

Moves @metamask/delegation-controller and @metamask/gator-permissions-controller to Vitest.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
    • Not applicable, test only change. Carries the no-changelog label.
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
    • None.

Note

Low Risk
Test-only and tooling changes; production controller code is unchanged.

Overview
Migrates @metamask/delegation-controller and @metamask/gator-permissions-controller from Jest to Vitest, following the same package-level pattern used elsewhere in the repo (shared vitest.config.packages.js, per-package vitest.config.ts with prior coverage thresholds).

For each package, test scripts and devDependencies switch to Vitest; Jest config and jest TypeScript types are removed. Test sources are updated mechanically (jest → vi, Vitest imports, vi.mock with dynamic import in gator-permissions, flushPromises from tests/vitest/helpers.js).

Repo wiring: both packages are dropped from the Jest runner map in test-runner-package-map.cjs, and oxlint-suppressions.json is adjusted (including vitest/no-conditional-in-test entries for gator-permissions tests).

Reviewed by Cursor Bugbot for commit 0267231. Bugbot is set up for automated code reviews on this repo. Configure here.

@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-delegation branch from 2e04298 to 5dea817 Compare October 21, 2026 11:13
@cryptodev-2s cryptodev-2s self-assigned this Oct 21, 2026
@cryptodev-2s
cryptodev-2s marked this pull request as ready for review October 21, 2026 11:31
@cryptodev-2s
cryptodev-2s requested review from a team as code owners October 21, 2026 11:31
@cryptodev-2s
cryptodev-2s added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit a551dfc Oct 21, 2026
370 checks passed
@cryptodev-2s
cryptodev-2s deleted the test/vitest-delegation branch October 21, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants