Skip to content

test: run local-nodes packages on Vitest - #10955

Merged
cryptodev-2s merged 2 commits into
mainfrom
test/vitest-local-nodes
Oct 22, 2026
Merged

cryptodev-2s merged 2 commits into
mainfrom
test/vitest-local-nodes

Conversation

@cryptodev-2s

@cryptodev-2s cryptodev-2s commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Explanation

Moves @metamask/bitcoin-regtest-up, @metamask/java-tron-up, @metamask/local-node-utils, @metamask/solana-test-validator-up, @metamask/stellar-quickstart-up, and @metamask/config-registry-controller to Vitest.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
    • Not applicable, test only change. Carries the no-changelog label.
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
    • None.

Note

Low Risk
Test-runner and devDependency changes only; production source is untouched aside from test file API swaps.

Overview
Migrates six workspaces from Jest to Vitest: local-node installers (bitcoin-regtest-up, java-tron-up, solana-test-validator-up, stellar-quickstart-up), shared local-node-utils, and config-registry-controller.

Each package drops jest.config.cjs and Jest-related devDependencies, adds a vitest.config.ts merged from the shared package base (with prior coverage thresholds and CLI bin exclusions preserved), and points test scripts at vitest. Tests are updated to import from vitest and use vi instead of jest (including fake timers and vi.mock(import(...)) in local-node-utils). TypeScript configs no longer include Jest types.

test-runner-package-map.cjs removes these packages from PACKAGES_ON_JEST, and oxlint-suppressions.json is adjusted (removed jest.config.cjs entries; added vitest/no-conditional-in-test suppressions for some install tests).

Reviewed by Cursor Bugbot for commit 7ebc022. Bugbot is set up for automated code reviews on this repo. Configure here.

@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-local-nodes branch 2 times, most recently from a94d664 to 30933ef Compare October 21, 2026 12:16
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-local-nodes branch from 30933ef to 03b1405 Compare October 21, 2026 19:09
@cryptodev-2s
cryptodev-2s marked this pull request as ready for review October 22, 2026 10:55
@cryptodev-2s
cryptodev-2s requested review from a team as code owners October 22, 2026 10:55
@cryptodev-2s cryptodev-2s self-assigned this Oct 22, 2026
@cryptodev-2s
cryptodev-2s requested a review from a team as a code owner October 22, 2026 10:55
@cryptodev-2s
cryptodev-2s deployed to default-branch October 22, 2026 10:55 — with GitHub Actions Active

@stanleyyconsensys stanleyyconsensys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cryptodev-2s
cryptodev-2s added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 5b04473 Oct 22, 2026
374 checks passed
@cryptodev-2s
cryptodev-2s deleted the test/vitest-local-nodes branch October 22, 2026 11:19

This branch was successfully deployed

1 active deployment
default-branch — 7ebc022d Deployed Oct 22, 2026 by cryptodev-2s via Determine whether this PR is a release PR #5856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants