Repository navigation
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (2 files, +15 -18)
🔐 @MetaMask/web3auth (1 files, +12 -19)
|
Contributor
Builds ready [8f6f17d]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
NidhiKJha
previously approved these changes
Oct 22, 2026
AndyMBridges
previously approved these changes
Oct 22, 2026
Contributor
Builds ready [975c55c]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 5 warn · 🔴 2 fail)
Bundle Size Diffs
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Builds ready [965f803]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
n3ps
force-pushed
the
n3ps/settings-back-fix
branch
from
October 22, 2026 16:45
965f803 to
50ff9fc
Compare
Contributor
Builds ready [50ff9fc]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [33701ce]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [aa0aef4]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [ea9e4d9]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
Contributor
Builds ready [94ee0ae]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 70c724a. Configure here.
Contributor
Builds ready [39736a8]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
cursor
Bot
force-pushed
the
n3ps/settings-back-fix
branch
from
October 23, 2026 03:18
39736a8 to
135fb3d
Compare
Contributor
Builds ready [135fb3d]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
cursor
Bot
force-pushed
the
n3ps/settings-back-fix
branch
from
October 23, 2026 04:06
135fb3d to
dc36918
Compare
Contributor
Builds ready [dc36918]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
Contributor
Builds ready [c473416]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve route when navigating back from Settings
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Navigation behavior changes for Settings and Shield claims affect core UX flows; incorrect fallback or history handling could strand users or drop tab state.
Overview
Settings back no longer jumps to a fixed home URL with the drawer open or to computed parent settings paths. It now uses
useInAppBack, so in-app history returns users to wherever they opened Settings (e.g. Perps / Money / Activity), withDEFAULT_ROUTEonly as a fallback when there is no in-app history.On Transaction Shield claims, the active tab is driven by the
tabquery param (updated on tab click withreplace) instead of local state that stripped the param from the URL. Back from a claim detail restores the tab the user had selected.Tests mock
useInAppBackand assert history-stylenavigate(-1)rather than explicit route targets.Reviewed by Cursor Bugbot for commit c473416. Bugbot is set up for automated code reviews on this repo. Configure here.