Repository navigation
chore: Expose dismissSidePanelMigrationToast through PrefController messenger - #47553
Merged
Merged
Conversation
Expose the `dismissSidePanelMigrationToast` method through the PreferencesController messenger so that we can access it through the root messenger instead of directly calling it. This will allow us to remove it as a method from `MetamaskController.getApi`.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
mcmire
changed the title
Contributor
Builds ready [fe1ffcc]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
|
mcmire
marked this pull request as ready for review
November 4, 2026 14:03
mcmire
had a problem deploying
to
segment-schema
November 4, 2026 14:03 — with 
GitHub Actions
Failure
GitHub Actions
Failure
cryptodev-2s
approved these changes
Nov 4, 2026
mcmire
enabled auto-merge
November 4, 2026 14:10
FrederikBolding
approved these changes
Nov 4, 2026
GuillaumeRx
approved these changes
Nov 4, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expose the
dismissSidePanelMigrationToastmethod through the PreferencesController messenger so that we can access it through the root messenger instead of directly calling it. This will allow us to remove it as a method fromMetamaskController.getApi.Changelog
CHANGELOG entry: null
Related issues
https://consensyssoftware.atlassian.net/browse/WPC-1557
Manual testing steps
This PR should have no functional changes. All flows should work like they do today, and the changes here should be covered by tests.
Screenshots/Recordings
(N/A)
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Messenger wiring and tests only; no change to dismissal logic or persisted preference behavior.
Overview
Registers
dismissSidePanelMigrationToaston the PreferencesController messenger (PreferencesController:dismissSidePanelMigrationToast) by adding it toMESSENGER_EXPOSED_METHODSand the generated method-action types union.Callers can dismiss the side-panel migration toast through the root messenger instead of going through
MetamaskController.getApi. Behavior is unchanged:showSidePanelMigrationToastis still set tofalse.Adds unit tests for direct invocation and
messenger.call('PreferencesController:dismissSidePanelMigrationToast').Reviewed by Cursor Bugbot for commit fe1ffcc. Bugbot is set up for automated code reviews on this repo. Configure here.