Repository navigation
fix: partial sign - #45
Merged
Merged
Conversation
adaOctopus
previously approved these changes
Jun 3, 2026
0xEdouardEth
force-pushed
the
fix-partial-sign
branch
2 times, most recently
from
June 4, 2026 09:39
8b94b60 to
f08e4a4
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
0xEdouardEth
force-pushed
the
fix-partial-sign
branch
from
June 4, 2026 10:40
7d2b40e to
c9f61ae
Compare
adaOctopus
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Test-dapp UI and dev/CI tooling only; no auth or on-chain signing logic beyond displaying the correct signature bytes.
Overview
Fixes partial sign display in
PartialSignTransactionby resolving the connected wallet’s signature fromstaticAccountKeysinstead of always showingsignatures[0](which could be the payer’s slot when the payer is not the connected account). Shows a clear message when no signature exists for the connected key.Also documents
VITE_RPC_HTTP_ENDPOINTin.env.example, pins vitest to3.1.1(lockfile aligned), and simplifies the compatibility-test CI job toyarn install --immutablewithout deleting/restoring the lockfile.Reviewed by Cursor Bugbot for commit 48d2ff8. Bugbot is set up for automated code reviews on this repo. Configure here.