Skip to content

fix: partial sign - #45

Merged
0xEdouardEth merged 3 commits into
mainfrom
fix-partial-sign
Jun 4, 2026
Merged

0xEdouardEth merged 3 commits into
mainfrom
fix-partial-sign

Conversation

@0xEdouardEth

@0xEdouardEth 0xEdouardEth commented Jun 3, 2026 •

Copy link
Copy Markdown
Contributor

Note

Low Risk
Test-dapp UI and dev/CI tooling only; no auth or on-chain signing logic beyond displaying the correct signature bytes.

Overview
Fixes partial sign display in PartialSignTransaction by resolving the connected wallet’s signature from staticAccountKeys instead of always showing signatures[0] (which could be the payer’s slot when the payer is not the connected account). Shows a clear message when no signature exists for the connected key.

Also documents VITE_RPC_HTTP_ENDPOINT in .env.example, pins vitest to 3.1.1 (lockfile aligned), and simplifies the compatibility-test CI job to yarn install --immutable without deleting/restoring the lockfile.

Reviewed by Cursor Bugbot for commit 48d2ff8. Bugbot is set up for automated code reviews on this repo. Configure here.

@0xEdouardEth
0xEdouardEth requested a review from a team as a code owner June 3, 2026 13:33
adaOctopus
adaOctopus previously approved these changes Jun 3, 2026
@socket-security

socket-security Bot commented Jun 4, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedvitest@​3.1.4 ⏵ 3.1.196 -12579 +199 +1100

View full report

@socket-security

socket-security Bot commented Jun 4, 2026 •

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@0xEdouardEth
0xEdouardEth merged commit 53465f1 into main Jun 4, 2026
22 checks passed
@0xEdouardEth
0xEdouardEth deleted the fix-partial-sign branch June 11, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants