Skip to content

fix: show welcome readiness for the selected provider - #269

Merged
hetaoBackend merged 1 commit into
mainfrom
fix/welcome-provider-status
Sep 21, 2026
Merged

hetaoBackend merged 1 commit into
mainfrom
fix/welcome-provider-status

Conversation

@hetaoBackend

@hetaoBackend hetaoBackend commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Change

A usable BYOK model without a MiniMax account was incorrectly shown as Login required because the shared prompt predicate treated any missing managed token as a login requirement. Align that predicate with the selected route's Agent access requirement; this also prevents a fresh BYOK session from reporting an automation error. Official Token Plan routes still prompt for login when credentials are absent or expired.

The welcome banner now distinguishes account checks, configuration warnings and unavailable account state from Ready, with /provider or /status guidance. Offline state alone no longer implies that official login is required. Provider warnings and account-service login gates remain intact.

Refs #267.

Validation

  • PASS: focused login-gate, visible-presentation and TUI application suites, 332 tests; standalone TypeScript check; git diff --check.
  • PASS: full pnpm verify on clean committed HEAD cfd83674fda01bf8338f7ff97bcc6a0898fd28df, macOS arm64 / Node 26.4.0. All 14 applicable gates passed, including 4,103 capability tests, build, source export, offline BYOK and sandbox checks. Release-package verification is not applicable to this source change.
  • PASS: built CLI launched in macOS PTYs using isolated synthetic profiles and the repository's network-denial fixture. Configured BYOK without managed login shows Ready and its model; explicit Token Plan without login preserves both login hints; an unavailable configured model shows Setup warning rather than Ready or a login prompt.
  • Regression coverage includes runtime warning projection, unknown/checking account state, builtin BYOK access and fresh automation readiness. Expired official credentials are covered by synthetic account state, not a live authentication flow.
  • Performance: basic; no performance-sensitive runtime path changed.
  • NOT RUN: live providers or official login/refresh services, Linux/Windows terminals, and other Node versions. Remote CI is pending.

Publication and contribution checks

  • I have permission to contribute these changes under the existing licenses applicable to the changed files/packages; existing notices are preserved.
  • No credentials, account data, real user content, internal source history or private review material is included.
  • Only existing source/test files changed; no inventory regeneration or new test registration is required.
  • No documentation contract changed. Offline results are not described as live-service acceptance.

Maintainer handoff

Publication scope and licenses are unchanged. Shared-source port: pending.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant