Repository navigation
Fix object identity APIs for Unity 6.4 and newer - #1136
Merged
keveleigh merged 3 commits intoSep 24, 2026
Merged
Conversation
Contributor
|
Looks good to me! Will pull it down and test it out. One note: please add changelog entries for these! |
Contributor
|
@gdgeek I went ahead and:
Hope that's okay! Running a few more local tests, then I'll merge |
keveleigh
enabled auto-merge (squash)
September 24, 2026 22:58
keveleigh
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unity 6.6 reports CS0619 for
Object.GetInstanceID(), preventing the Input and SpatialManipulation editor assemblies from compiling.Use
GetEntityId()on Unity 6.4 and newer while retainingGetInstanceID()on earlier editors. Controller mapping validation stores fullEntityIdvalues, includingEntityId.Nonefor empty or missing references, so duplicate detection retains its existing behavior without narrowing IDs toint. The constraint manager label and the "Go to component" highlight query both use the same ID API.Fixes #1134.
Validation
git diff --check: passed.The direct compiler checks use existing MRTK dependency assemblies. They do not replace interactive Inspector checks, a full project migration, or device testing. Unity versions earlier than 6.4 were not installed for execution; their original code paths are preserved.