Skip to content

remove dead commented-out validate() stub - #2830

Closed
yashrajshuklaaa wants to merge 1 commit into
NVIDIA:mainfrom
yashrajshuklaaa:rm-dead-validate-stub
Closed

remove dead commented-out validate() stub#2830
yashrajshuklaaa wants to merge 1 commit into
NVIDIA:mainfrom
yashrajshuklaaa:rm-dead-validate-stub

Conversation

@yashrajshuklaaa

Copy link
Copy Markdown

Description

Removes an unused, commented-out validate() function stub and its TODO comment in state_manager.go.
Never implemented, nothing references it. No functional changes.

Testing

Ran go build ./controllers/... and full go test ./controllers/... -v, all pass.

Signed-off-by: Yashraj Shukla <shuklayashraj68@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: d39eea64-d149-49c4-88f8-d3e96188e495

📥 Commits

Reviewing files that changed from the base of the PR and between fa49ea6 and 66e2a0b.

📒 Files selected for processing (1)
  • controllers/state_manager.go
💤 Files with no reviewable changes (1)
  • controllers/state_manager.go

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Walkthrough

Removed the obsolete commented-out ClusterPolicyController.validate placeholder and its custom-validation TODO from controllers/state_manager.go. No exported or public entities changed.

Merge Risk: ⚪ Minimal · up to 66e2a

This change removes an unused commented-out validation stub without changing runtime behavior; no actionable merge-blocking risk remains after normal checks and review.


Comment @coderabbitai help to get the list of available commands.

@rahulait

Copy link
Copy Markdown
Contributor

@yashrajshuklaaa thanks for the PR. Can you merge your two PRs into one?

@yashrajshuklaaa
yashrajshuklaaa deleted the rm-dead-validate-stub branch August 29, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants