Skip to content

Cleanup stale todos - #2832

Open
yashrajshuklaaa wants to merge 2 commits into
NVIDIA:mainfrom
yashrajshuklaaa:cleanup-stale-todos
Open

Cleanup stale todos#2832
yashrajshuklaaa wants to merge 2 commits into
NVIDIA:mainfrom
yashrajshuklaaa:cleanup-stale-todos

Conversation

@yashrajshuklaaa

Copy link
Copy Markdown

Description

Combines two small cleanup changes (previously #2830 and a separate nodepool.go PR, merged per reviewer request):

  1. Removes an unused, commented-out validate() function stub and its TODO comment in state_manager.go.
    Never implemented, nothing references it.
  2. Removes a stale // TODO: add unit tests comment in nodepool.go.
    Test coverage already exists in nodepool_test.go (6 test functions).

No functional changes in either commit.

Testing

go build ./... and full test suite for controllers and internal/state packages, all pass.

Signed-off-by: Yashraj Shukla <shuklayashraj68@gmail.com>
Signed-off-by: Yashraj Shukla <shuklayashraj68@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 280acea8-e322-4db2-9a2a-c2bb7fd10368

📥 Commits

Reviewing files that changed from the base of the PR and between fa49ea6 and 52fb781.

📒 Files selected for processing (2)
  • controllers/state_manager.go
  • internal/state/nodepool.go
💤 Files with no reviewable changes (2)
  • controllers/state_manager.go
  • internal/state/nodepool.go

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Walkthrough

Removed an obsolete commented-out ClusterPolicyController.validate placeholder from controllers/state_manager.go. Removed an obsolete unit-test TODO from internal/state/nodepool.go. No public declarations or runtime behavior changed.

Merge Risk: ⚪ Minimal · up to 52fb7

This change removes obsolete TODOs and an unused code stub without changing behavior; no actionable merge-blocking risk remains after normal checks and review.


Comment @coderabbitai help to get the list of available commands.

@yashrajshuklaaa

Copy link
Copy Markdown
Author

@rahulait done! ptal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant