Skip to content

Cleanup stale todos #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yashrajshuklaaa wants to merge 2 commits into
base: main
Choose a base branch
from
+0 −6
Open

Cleanup stale todos #2832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66e2a0b
remove dead commented-out validate() stub
yashrajshuklaaa Aug 29, 2026
52fb781
nvd: remove stale TODO for nodepool unit tests
yashrajshuklaaa Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions controllers/state_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,11 +993,6 @@ func (n *ClusterPolicyController) step() (gpuv1.State, error) {
return result, nil
}

// TODO
// func (n ClusterPolicyController) validate() {
// add custom validation functions
// }

func (n ClusterPolicyController) last() bool {
return n.idx == len(n.controls)
}
Expand Down
1 change: 0 additions & 1 deletion internal/state/nodepool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ const (
)

// TODO: move this code to it's own module?
// TODO: add unit tests
type nodePool struct {
name string
osRelease string
Expand Down