remove stale TODO for nodepool unit tests - #2829
Closed
yashrajshuklaaa wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Yashraj Shukla <shuklayashraj68@gmail.com>
yashrajshuklaaa
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
August 28, 2026 23:46
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe change removes the obsolete Merge Risk: ⚪ Minimal · up to This change only removes a stale documentation comment and does not alter runtime behavior, so no actionable merge-blocking risk remains after normal checks and review. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes a stale
// TODO: add unit testscomment on thenodePooltype ininternal/state/nodepool.go.Test coverage for
getOSTagandgetNodePoolsalready exists innodepool_test.go(6 test functions).No functional changes.
Testing
Ran
go build ./internal/state/...and the existingnodepool_test.gosuite locally, all pass. No new tests needed.