Repository navigation
fix: normalize no longer throws on tokens such as "constructor" - #803
Open
OsamaAnsar wants to merge 1 commit into
Open
OsamaAnsar wants to merge 1 commit into
OsamaAnsar wants to merge 1 commit into
Conversation
The conversion table was read with a plain property lookup, so a token that is the name of an inherited object property (constructor, __proto__) found that property instead of a conversion and the call to split threw a TypeError.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
normalizethrows when a token is the name of a property that every object inherits:The conversion table is a plain object and is read with
conversionTable[token.toLowerCase()]. Forconstructorthat findsObject.prototype.constructor, which is truthy and has nosplit.__proto__fails the same way.The change only accepts the table's own keys. One new spec covers
constructor,Constructor,__proto__and the string form; it fails without the change.npm test(899 specs) andnpm run lintpass.