Repository navigation
fix: RegexpTokenizer keeps empty tokens when discardEmpty is false - #804
Open
OsamaAnsar wants to merge 1 commit into
Open
OsamaAnsar wants to merge 1 commit into
OsamaAnsar wants to merge 1 commit into
Conversation
The option was read as options.discardEmpty || true, which is always true, so discardEmpty: false had no effect.
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
discardEmptyoption ofRegexpTokenizercannot be turned off:The constructor reads it as
options.discardEmpty || true, which is alwaystrue.The change defaults to
trueonly when the option is not given, the same waygapsis handled a few lines below. Nothing in the library passesdiscardEmpty: false, so the other tokenizers behave as before. A newspec/regexp_tokenizer_spec.tscovers the default,trueandfalse; thefalsespec fails without the change.npm test(901 specs) andnpm run lintpass.