Repository navigation
fix: count __proto__ terms in TF-IDF documents - #809
Open
xiaoyao-666-coder wants to merge 1 commit into
Open
xiaoyao-666-coder wants to merge 1 commit into
xiaoyao-666-coder wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addDocument('__proto__ __proto__ ordinary')silently drops both occurrences of__proto__: its term frequency and TF-IDF score are zero, andlistTerms()omits it. The default tokenizer preserves the token, but the plain-object frequency map cannot store it through normal assignment. Token-array input has the same problem.Proposed Changes
__keymetadata. This makes__proto__an ordinary own property and removes the function-name workaround from Tfidf scoring doesnt work for the word 'constructor' #119. Prebuilt document objects are still passed through unchanged.For a corpus containing
__proto__ __proto__ ordinaryandordinary,tfidfs('__proto__')changes from[0, 0]to[2, 0], as required by the documented TF-IDF formula.This complements #785: that fix guarded term/cache reads, while this fixes counts lost during document construction. Generated
documentsentries now have no inherited Object methods, consistent with the IDF cache. JSON serialization continues to work.Validation
On Node 24.22.1 / Windows:
npm test: 902 specs, 0 failuresnpm run build:testsandnpm run lintlib/natural/tfidf/tfidf.jsnpm run build:esmandnpm run smoke:esmgit diff --checkThe database-backed I/O suite was not run. Companion documentation targets
gh-pagesin #810, as requested by CONTRIBUTING.md.Checklist before merging
Prepared with Codex assistance.