Repository navigation
fix: avoid stack overflow in Trie subtree traversal - #811
Open
xiaoyao-666-coder wants to merge 1 commit into
Open
xiaoyao-666-coder wants to merge 1 commit into
xiaoyao-666-coder wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After inserting a 50,000-character key,
contains()succeeds butgetSize()andkeysWithPrefix('')both throwRangeError: Maximum call stack size exceeded. The remaining recursive subtree walks cannot handle the depth that iterative insertion now supports.Proposed Changes
This follows up on #780, which deliberately left these recursive walks unchanged. It does not modify the case-sensitivity condition addressed by #802. No public signature or type declaration changes are needed.
Validation
On Node 24.22.1 / Windows:
npm test: 903 specs, 0 failuresnpm run build:testsandnpm run lintlib/natural/trie/trie.jsnpm run build:esmandnpm run smoke:esmgit diff --checkThe database-backed I/O suite was not run. Companion documentation targets
gh-pagesin #812, as required by CONTRIBUTING.md.Checklist before merging
Prepared with Codex assistance.