Repository navigation
fix: return neutral sentiment for empty input - #813
Open
xiaoyao-666-coder wants to merge 1 commit into
Open
xiaoyao-666-coder wants to merge 1 commit into
xiaoyao-666-coder wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getSentiment([])returnsNaNbecause the accumulated score is divided by zero. This also affects normal tokenizer pipelines: empty, whitespace-only, and punctuation-only text produces no words withWordTokenizer.Proposed Changes
0when the input array is empty, before dividing by its length.Nonempty inputs follow the existing scoring path. No public signature or TypeScript declaration changes are needed.
Validation
On Node 24.22.1 / Windows:
NaNinstead of0)npm test: 906 specs, 0 failuresnpm run build:testsandnpm run lintSentimentAnalyzer.jsnpm run build:esmandnpm run smoke:esmgit diff --checkThe database-backed I/O suite was not run. Companion documentation targets
gh-pagesin #814, as required by CONTRIBUTING.md.Checklist before merging
Prepared with Codex assistance.