Skip to content

[16.0][MIG] report_py3o_signer - #837

Open
benwillig wants to merge 5 commits into
OCA:16.0from
acsone:16.0-mig-report_py3o_signer-bwi
Open

[16.0][MIG] report_py3o_signer#837
benwillig wants to merge 5 commits into
OCA:16.0from
acsone:16.0-mig-report_py3o_signer-bwi

Conversation

@benwillig

@benwillig benwillig commented Jan 10, 2024

Copy link
Copy Markdown

Based on #836

@len-foss

len-foss commented Jan 17, 2024 •
edited
Loading

Copy link
Copy Markdown

Is this really a migration? After searching dead PRs I found #523
A bit annoying that it was never merged as I duplicated the effort in #821.

Also there seems to be an error: you could generate py3o documents in native formats, so the code from our PR is a bit more robust. And there's a test class provided. I've slightly refactored to avoid too much duplication too. Could we merge the efforts?

@benwillig
benwillig force-pushed the 16.0-mig-report_py3o_signer-bwi branch 2 times, most recently from 071d7e8 to 80caead Compare March 27, 2024 13:56
@github-actions

github-actions Bot commented Jul 28, 2024

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 28, 2024
@github-actions github-actions Bot closed this Sep 1, 2024
@yvaucher yvaucher removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 4, 2026
@yvaucher yvaucher reopened this Sep 4, 2026
@yvaucher

yvaucher commented Sep 4, 2026

Copy link
Copy Markdown
Member

/ocabot migration report_py3o_signer

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 4, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 4, 2026
Open
16 tasks
@yvaucher yvaucher mentioned this pull request Sep 4, 2026
Closed
@yvaucher

yvaucher commented Sep 4, 2026

Copy link
Copy Markdown
Member

To rebase

@yvaucher
yvaucher force-pushed the 16.0-mig-report_py3o_signer-bwi branch from 80caead to 5c6fb16 Compare September 4, 2026 10:11
@OCA-git-bot OCA-git-bot added series:16.0 mod:report_py3o_signer Module report_py3o_signer labels Sep 4, 2026
@yvaucher
yvaucher requested a review from len-foss September 4, 2026 10:13
yvaucher
yvaucher approved these changes Sep 4, 2026
View reviewed changes

@yvaucher yvaucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@len-foss

len-foss commented Sep 4, 2026

Copy link
Copy Markdown

Hello @yvaucher
Were any of my comments addressed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yvaucher yvaucher yvaucher approved these changes
@len-foss len-foss Awaiting requested review from len-foss
+1 more reviewer
@ThomasBinsfeld ThomasBinsfeld ThomasBinsfeld approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:report_py3o_signer Module report_py3o_signer needs fixing series:16.0

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

5 participants

@benwillig @len-foss @yvaucher @ThomasBinsfeld @OCA-git-bot