[18.0][IMP] base_tier_validation: default comment approve - #1298
Open
Saran440 wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @LoisRForgeFlow, |
OCA-git-bot
added
series:18.0
mod:base_tier_validation
Contributor
|
This PR has the |
CristianoMafraJunior
approved these changes
Aug 13, 2026
Member
Author
|
@LoisRForgeFlow Hi, this PR has already been approved. Could you please share your thoughts on this change? |
LoisRForgeFlow
requested changes
Sep 3, 2026
Comment on lines
+97
to
+99
| comment_approve_default = fields.Char( | ||
| string="Approve Comment", | ||
| ) |
Contributor
There was a problem hiding this comment.
Can you add a help message so it is clear what this new field do? The name is too generic and can be misleading for users seeing it for the first time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, comments are required for both approval and rejection.
From a business perspective, rejection should usually include a reason, but approval often does not. By allowing a default approval comment, users can approve requests without entering a comment manually each time.
This PR adds config a default approval comment, which is automatically filled in the approval wizard.