Skip to content

- updated contributors & removed bad contributor code \n - moved las… - #2654

Merged
commjoen merged 1 commit into
masterfrom
bugfixes/test-anditerations
Sep 8, 2026
Merged

- updated contributors & removed bad contributor code \n - moved las…#2654
commjoen merged 1 commit into
masterfrom
bugfixes/test-anditerations

Conversation

@commjoen

@commjoen commjoen commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

…t 2 challenges one number down \n - fixed test

What kind of changes does this PR include?

  • Fixes or refactors: moved challenge 70 and 71 one spot
  • A new challenge
  • Additional documentation: added contributors
  • Something else: fixed a unit test

Description

Relations

References

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I used AI to generate parts of the content.
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

…t 2 challenges one number down \n - fixed test
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

🌐 GitHub Pages Preview Ready!

Your static preview is now available at:
🔗 Preview PR #2654

📄 What's included:

For full functionality testing: Use the Docker preview instead.

🔄 Auto-updates: This preview will be updated automatically when you push new commits to this PR.


Static preview with Thymeleaf generation by GitHub Actions

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

📸 Visual Diff Available!

Screenshots have been generated comparing your changes with the main branch.

Download Visual Diff Artifacts

The artifacts contain:

  • pr-home.png - Your version of the home page
  • main-home.png - Current main branch home page
  • pr-about.png - Your version of the about page
  • main-about.png - Current main branch about page

Compare these images to see the visual impact of your changes!


Visual diff generated by GitHub Actions

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

🔨 Preview Build Complete!

Your changes have been built and pushed to GitHub Container Registry.

🐳 Docker Image: ghcr.io/owasp/wrongsecrets/wrongsecrets-pr:pr-2654-d325038

📦 Download & Test Locally:

  1. 📁 Download Docker Image Artifact (look for wrongsecrets-preview-pr-2654)
  2. Load and run the image:
# Download the artifact, extract it, then:
docker load < wrongsecrets-preview.tar
docker run -p 8080:8080 -p 8090:8090 wrongsecrets-preview

🚀 Alternative - Pull from Registry:

docker pull ghcr.io/owasp/wrongsecrets/wrongsecrets-pr:pr-2654-d325038
docker run -p 8080:8080 -p 8090:8090 ghcr.io/owasp/wrongsecrets/wrongsecrets-pr:pr-2654-d325038

Then visit: http://localhost:8080

📝 Changes in this PR:
- src/main/java/org/owasp/wrongsecrets/AllControllerAdvice.java
- src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge69.java
- src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge69Controller.java
- src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge70.java
- src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge70Controller.java
- src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge71.java
- src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge71Controller.java
- src/main/resources/explanations/challenge69.adoc
- src/main/resources/explanations/challenge69_hint.adoc
- src/main/resources/explanations/challenge69_reason.adoc
- ... and 7 more files

Visual diff screenshots will be available shortly...


Preview built by GitHub Actions

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

📸 Visual Diff Ready!

Screenshots comparing your changes with the main branch are available:

📁 Download Visual Diff Artifacts

🖼️ Included screenshots:

  • pr-home.png vs main-home.png - Welcome page comparison
  • pr-about.png vs main-about.png - About page comparison
  • pr-challenge.png vs main-challenge.png - Challenge page comparison

🔍 How to review:

  1. Download the artifact zip file
  2. Extract and compare the pr-* and main-* images side by side
  3. Look for visual differences in layout, styling, and content

💡 Tip: Use an image comparison tool or open both images in separate browser tabs to spot differences easily.


Visual diff generated by GitHub Actions • PR #2654

@commjoen
commjoen merged commit 6af089a into master Sep 8, 2026
21 checks passed
@commjoen
commjoen deleted the bugfixes/test-anditerations branch September 8, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant