Skip to content

Accept CoreAudio slices on devices slower than 48 kHz #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thebornster wants to merge 1 commit into from
Closed

Accept CoreAudio slices on devices slower than 48 kHz #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions glue/rexglue-sdk-main/src/audio/coreaudio/coreaudio_output.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,13 @@ bool CoreAudioOutput::ConfigureDevice() {
kAudioUnitScope_Global, 0, &maximum_frames,
&maximum_frames_size) == noErr &&
maximum_frames) {
// The slice limit is in device frames; on a slower device the sample-rate converter pulls
// proportionally more 48 kHz client frames per slice (e.g. 279 for 256 at 44.1 kHz).
if (nominal_rate > 0 && nominal_rate < kGuestAudioSampleRate) {
maximum_frames = static_cast<UInt32>(
std::ceil(maximum_frames * (kGuestAudioSampleRate / nominal_rate))) +
1;
}
maximum_frames_per_slice_.store(maximum_frames, std::memory_order_release);
}

Expand Down