app/eth1wrap: avoid startup hang when execution client is silent - #4694
Open
b0a7 wants to merge 2 commits into
Open
app/eth1wrap: avoid startup hang when execution client is silent#4694b0a7 wants to merge 2 commits into
b0a7 wants to merge 2 commits into
Conversation
Reproduce charon#4689: ClientVersion can hang after RPC timeout when reconnectCh is full, wedging WaitConnected / startup against a silent EL. Co-authored-by: Cursor <cursoragent@cursor.com>
Make maybeReconnect non-blocking and do not hold the client mutex across RPC calls so WaitConnected can time out instead of deadlocking (charon#4689). Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid eth1wrap startup deadlock when the execution client accepts connections but never answers JSON-RPC.
Make reconnect signaling non-blocking and do not hold the client mutex across RPC calls, so WaitConnected can time out instead of wedging the process. Also bound the Run-loop liveness probe. Adds regression tests for the ClientVersion hang and non-blocking reconnect signal.
category: bug
ticket: #4689