Skip to content

core/scheduler: fix flaky TestSchedulerWait clock rewind #4726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KaloyanTanev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

core/scheduler: fix flaky TestSchedulerWait clock rewind #4726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/scheduler/scheduler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,6 +727,13 @@ func (c *testClock) After(d time.Duration) <-chan time.Time {
}

func (c *testClock) Sleep(d time.Duration) {
// A non-positive duration fires immediately on a real clock and must never move time
// backwards. The slot ticker legitimately calls After with a non-positive duration for the
// current slot, which would otherwise rewind the fake clock and race with the test.
if d <= 0 {
return
}

for c.paused.Load() {
runtime.Gosched()
}
Expand Down
Loading