chore: fix spelling across comments, identifiers and query tags - #448
Merged
Conversation
Closed
jsoref
reviewed
Aug 14, 2026
NickJosevski
force-pushed
the
chore/spelling-204
branch
from
August 20, 2026 07:11
806f3b4 to
d06b5bd
Compare
Rebases the corrections from #204 onto main. Three are behavioural rather than cosmetic: the events query sent "interal" so the Internal filter never reached the server, ManualInterverventionApprove gains a correctly spelled name while the misspelling stays as a deprecated alias, and uritemplates.parseTerm's error text changes from "modifers" to "modifiers". The parseTerm message is observable to anyone matching on that string, so it is called out for release notes even though it is an internal parse error. Co-Authored-By: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
NickJosevski
force-pushed
the
chore/spelling-204
branch
from
August 20, 2026 07:19
d06b5bd to
5cc1f73
Compare
YuKitsune
approved these changes
Aug 20, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #204, which had gone stale and conflicting. Same corrections, rebased onto
main, with @jsoref credited as co-author.Mostly comments and local identifiers, but three are behaviour, not spelling:
pkg/events/events_query.go—Internalwas taggeduri:"interal". The server's link template is/api/events{?...,internal,...}, so the tag never matched and the filter silently expanded to nothing. Confirmed against a live instance. Same class as Feat: Add GetDashboard for the non-dynamic dashboard endpoint #442, [BUG] ReleaseTemplateGitResource.GitCredentialId has the wrong JSON tag and never deserialises #443 and [BUG] DeploymentProcessService.Get returns an empty process and a nil error when the project's Links are unpopulated #444. Callers that setInternalwere getting unfiltered results and will now get filtered ones.pkg/interruptions/interruption.go—ManualInterverventionApproveis exported, so chore: Spelling #204's outright rename would have been breaking. AddedManualInterventionApproveand kept the misspelling as a deprecated alias instead.uritemplates/uritemplates.go:188— theparseTermerror text changes from"both explode and prefix modifers on same term"to"...modifiers...". It's an internal URI-template parse error, but the string is observable to anyone matching on the message, so it belongs in the release notes rather than being filed under comment fixes.Not breaking
No compile-level break.
ManualInterverventionApprovesurvives as an alias with the same value, and every other renamed identifier is a doc comment, a local variable, a commented-out test, or — inpkg/machines/ssh_endpoint.go— a field on the anonymous struct declared insideMarshalJSON, whosejsontag was already correct. Nothing changes on the wire.Note on
api/spec.jsonDeploymentPromomotionTenant→DeploymentPromotionTenantmatches how the server actually spells it. TheDefaultParamterValueMissing→DefaultParameterValueMissinghunk is more debatable: that's a wire enum value onActionUpdateResultResource, and a live server still emits the misspelling, so the "fix" makes the checked-in spec diverge from reality. Nothing in this repo readsspec.json, so it can't break a build — flagging it for a reviewer to call.Omitted
Deliberately left out of #204's set:
pkg/machines/duration_formatter_test.go(fourtySevenHours). #435 rewrites that file, and touching it here would only create a conflict — worth picking up after that merges.Two stray
.DS_Storefiles that had been committed are removed, and.DS_Storeis now in.gitignore.Verification
go build,go vetandgofmtclean, andapi/spec.jsonstill parses. (uritemplates/uritemplates.gois unformatted pergofmt, but identically so onmain— a trailing//in the package doc comment, untouched here.) The fullpkg/...suite has the same failures before and after this change — all integration tests against a live instance, and the set varies between consecutive runs onmainalone.🤖 Generated with Claude Code