Skip to content

chore: fix spelling across comments, identifiers and query tags - #448

Merged
NickJosevski merged 1 commit into
mainfrom
chore/spelling-204
Aug 21, 2026
Merged

chore: fix spelling across comments, identifiers and query tags#448
NickJosevski merged 1 commit into
mainfrom
chore/spelling-204

Conversation

@NickJosevski

@NickJosevski NickJosevski commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Replaces #204, which had gone stale and conflicting. Same corrections, rebased onto main, with @jsoref credited as co-author.

Mostly comments and local identifiers, but three are behaviour, not spelling:

Not breaking

No compile-level break. ManualInterverventionApprove survives as an alias with the same value, and every other renamed identifier is a doc comment, a local variable, a commented-out test, or — in pkg/machines/ssh_endpoint.go — a field on the anonymous struct declared inside MarshalJSON, whose json tag was already correct. Nothing changes on the wire.

Note on api/spec.json

DeploymentPromomotionTenantDeploymentPromotionTenant matches how the server actually spells it. The DefaultParamterValueMissingDefaultParameterValueMissing hunk is more debatable: that's a wire enum value on ActionUpdateResultResource, and a live server still emits the misspelling, so the "fix" makes the checked-in spec diverge from reality. Nothing in this repo reads spec.json, so it can't break a build — flagging it for a reviewer to call.

Omitted

Deliberately left out of #204's set: pkg/machines/duration_formatter_test.go (fourtySevenHours). #435 rewrites that file, and touching it here would only create a conflict — worth picking up after that merges.

Two stray .DS_Store files that had been committed are removed, and .DS_Store is now in .gitignore.

Verification

go build, go vet and gofmt clean, and api/spec.json still parses. (uritemplates/uritemplates.go is unformatted per gofmt, but identically so on main — a trailing // in the package doc comment, untouched here.) The full pkg/... suite has the same failures before and after this change — all integration tests against a live instance, and the set varies between consecutive runs on main alone.

🤖 Generated with Claude Code

@NickJosevski NickJosevski mentioned this pull request Aug 14, 2026
Comment thread pkg/.DS_Store Outdated
Comment thread test/.DS_Store Outdated
Rebases the corrections from #204 onto main. Three are behavioural rather
than cosmetic: the events query sent "interal" so the Internal filter
never reached the server, ManualInterverventionApprove gains a correctly
spelled name while the misspelling stays as a deprecated alias, and
uritemplates.parseTerm's error text changes from "modifers" to
"modifiers".

The parseTerm message is observable to anyone matching on that string, so
it is called out for release notes even though it is an internal parse
error.

Co-Authored-By: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@NickJosevski
NickJosevski merged commit 4b5c53c into main Aug 21, 2026
5 checks passed
@NickJosevski
NickJosevski deleted the chore/spelling-204 branch August 21, 2026 00:36
@jsoref jsoref mentioned this pull request Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants