feat: TOC physical rehome + page_memory render scope isolation - #336
Open
EricNGOntos wants to merge 4 commits into
Open
feat: TOC physical rehome + page_memory render scope isolation#336EricNGOntos wants to merge 4 commits into
EricNGOntos wants to merge 4 commits into
Conversation
- Introduced new functions for rehoming calibrated forests and handling pending records in the TOC anchoring process. - Updated the `compute_fat_leaf_pages` function to exclude TOC pages from the fat span test, ensuring accurate page calculations. - Refactored various functions to utilize the new `pages_excluding_toc` utility for consistent TOC page exclusion across multiple components. - Removed the deprecated `TocPagePolicy` class, streamlining the codebase. - Added tests to validate the exclusion of TOC pages in fat leaf calculations.
- Updated the hierarchy locator to better handle rehome matches and leaf nodes, ensuring accurate page range resolution. - Introduced new functions for managing rehome ranges and structural leaf identification, improving the clarity and efficiency of the code. - Enhanced the TOC anchoring process to support global paged-leaf rehome, allowing for more robust handling of TOC structures. - Refactored tests to validate the new rehome logic and ensure correct behavior in various scenarios.
- Updated the rendering logic to support a new naming convention for PNG files, allowing for better organization based on the presence of a prefix. - Refactored the inspection process to render pages serially before conducting concurrent inspections, improving efficiency and clarity in the workflow. - Adjusted the handling of rendered pages in the inspection function to ensure proper coverage and error handling. - Enhanced tests to validate the new rendering and inspection behavior, ensuring robustness in various scenarios.
Unblocks make check before PR sync. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pages/{scope_id}/page-{n}.pngto stop concurrent boundary-page truncate races; reject empty image base64 before VLM.toc_pagesplumbing and stage5extract_toc_nodesimport for lint/CI.Test plan
make check(ruff + pyright)base64 empty; EXIT_DELAY only DEBUGMade with Cursor