fix: replace insecure eval() with safe parsing in reflection.py - #167
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Replaces the command execution vulnerability in ReflectionAgent where LLM-generated output was directly evaluated. The fix uses regex parsing and ast.literal_eval for safe argument extraction, then getattr() to call the appropriate method. Fixes security issue reported in OpenBMB#147
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the command execution vulnerability in
ReflectionAgentwhere LLM-generated output was directly evaluated usingeval().Why
Issue #147 reported a security vulnerability: the code used
eval("self._" + output)to process LLM responses, which could allow command execution if the LLM output was manipulated by an attacker.How
The fix replaces
eval()with:say(,act(,do_nothing()ast.literal_eval()for safe argument parsinggetattr()to call the appropriate internal method (_sayor_act)This ensures only the expected method calls can be made with safely-parsed arguments.
Testing
_say()or_act()Related Issue
Fixes #147
Security Note
This is a security fix. The original code allowed arbitrary code execution through LLM prompt injection. The new code restricts execution to only the
_say,_act, anddo_nothingmethods with safely parsed arguments.