Conversation
Contributor
|
I suggest checking the develop or new-design branches first to see whether this patch is still needed. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an old
TODOin the codebase regarding environment variable fetching.Previously, the project used a custom
environmentVariablefunction as a fallback toqgetenv. There was a comment insrc/shared/FileSystem.hstating:// TODO: Use qEnvironmentVariable function when we are able to use Qt 5.10 version.Since the project now uses a modern Qt version that fully supports
qEnvironmentVariable(), this custom implementation is no longer necessary. This PR removes the legacy tech debt and switches to the native Qt function.Changes Made
environmentVariablefunction definition and declaration fromsrc/shared/FileSystem.cppandsrc/shared/FileSystem.h.UserFolders()insrc/shared/FileSystem.hto useqEnvironmentVariable().TopBar::DataMigration()insrc/frontend/TopBar.cppto useqEnvironmentVariable().TODOcomment.Testing
This is a safe refactor.
qEnvironmentVariable()is the standard, cross-platform Qt method for fetching environment variables and behaves identically to the customqgetenvwrapper it replaces.