Skip to content

[PATCH v2] github_ci: remove redundant and low value build jobs to speed up CI - #2401

Open
JannePeltonen wants to merge 3 commits into
OpenDataPlane:masterfrom
JannePeltonen:ci-job-cleanup
Open

JannePeltonen wants to merge 3 commits into
OpenDataPlane:masterfrom
JannePeltonen:ci-job-cleanup

Conversation

@JannePeltonen

Copy link
Copy Markdown
Collaborator

Remove a bunch of --enable-abi-compat build jobs as well as -Os and -O1 build jobs as they do not add much coverage, if at all.

@github-actions github-actions Bot changed the title github_ci: remove redundant and low value build jobs to speed up CI [PATCH v1] github_ci: remove redundant and low value build jobs to speed up CI Sep 14, 2026

@TuomasTaipale TuomasTaipale left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional comment, otherwise the pruning is fine at least to me.

Comment on lines 137 to +138
matrix:
conf: ['', '--enable-abi-compat']
conf: ['']

@TuomasTaipale TuomasTaipale Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The matrix block in some jobs now doesn't do anything leaving some bloat. I guess they could be left for easy additions in the future but on the other hand, the config listing doesn't seem to vary much historically.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the empty matrices there because I did not want to touch all the run lines that refer to them.

Remove build testing with -Os and -O1 as redundant. Other optimization
levels, including -O0, -O2 (the default) and -O3, are still tested and
a build breakage that would show up only with -Os or -O1 is unlikely.

Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com>
Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com>
ABI compatibility is not a widely used feature but gets tested rather
heavily. Remove --enable-abi-compat from jobs that exercise different
compiler versions, since problems in the ABI compatibility implementation
are unlikely to show up only with certain compiler versions.

Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com>
Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Exclude the combination of Clang and ABI compatibility from the cross
compilation build jobs for arm64, armhf, i386 and ppc64el. Building
the ABI compat variants with both GCC and Clang adds little value
over testing ABI compat build with GCC only in these jobs.

Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com>
Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com>
@github-actions github-actions Bot changed the title [PATCH v1] github_ci: remove redundant and low value build jobs to speed up CI [PATCH v2] github_ci: remove redundant and low value build jobs to speed up CI Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants