Skip to content

3D Printing Canada: add Budget PLA and PETG temperatures from the vendor datasheets, correct PLA density and PETG tolerance #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coffandro merged 3 commits into from
Oct 31, 2026
Merged

3D Printing Canada: add Budget PLA and PETG temperatures from the vendor datasheets, correct PLA density and PETG tolerance #801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80625c8
3D Printing Canada Budget PLA: add print and bed temperatures, correc…
csmarshall Oct 26, 2026
2970a52
3D Printing Canada Budget PETG: add print and bed temperatures, corre…
csmarshall Oct 26, 2026
77aabd7
Apply batched suggestions from code review
coffandro Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions data/3d_printing_canada/PETG/budget_petg/filament.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@
"uuid": "f3f20549-e2f4-4155-a1fb-3c81bbcefa0d",
"id": "budget_petg",
"name": "Budget PETG",
"diameter_tolerance": 0.03,
"diameter_tolerance": 0.05,
Comment thread
coffandro marked this conversation as resolved.
Resolved
"density": 1.27,
"max_dry_temperature": 65
"max_dry_temperature": 65,
"min_print_temperature": 230,
"max_print_temperature": 260,
"min_bed_temperature": 70,
"max_bed_temperature": 90,
Comment thread
coffandro marked this conversation as resolved.
Resolved
"enclosure": "not_needed",

@github-actions github-actions Bot Oct 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Same as the PLA file: enclosure is not in the filament schema. Add it to the schema or remove it. (unverified: AI opinion)

"data_sheet_url": "https://cdn.shopify.com/s/files/1/2719/6506/files/3DPC_Budget_PETG_1.75mm_TDS.pdf"

@github-actions github-actions Bot Oct 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 The TDS PDF is reachable and branded for this line, which is enough. The PETG product page does not link it, though, so the URL was located by pattern. Confirm the file name against the vendor's PETG listing if you can. (unverified: AI opinion)

}
10 changes: 8 additions & 2 deletions data/3d_printing_canada/PLA/budget_pla/filament.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
"id": "budget_pla",
"name": "Budget PLA",
"diameter_tolerance": 0.05,
"density": 1.24,
"max_dry_temperature": 50
"density": 1.26,
"max_dry_temperature": 50,
"min_print_temperature": 190,
"max_print_temperature": 230,
"min_bed_temperature": 55,
"max_bed_temperature": 65,
Comment thread
coffandro marked this conversation as resolved.
Resolved
"enclosure": "not_needed",

@github-actions github-actions Bot Oct 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 enclosure is not defined in schemas/filament_schema.json, and the root object sets additionalProperties to false, so this key should fail validation. No other entry in the repo uses it. Either add the field to the schema in this PR or drop the key from both files (the same applies to the PETG file). (unverified: AI opinion)

"data_sheet_url": "https://cdn.shopify.com/s/files/1/2719/6506/files/3DPC_Budget_PLA_1.75mm_TDS.pdf"
}
Loading