Add missing p11_ver.h file to installed headers#662
Merged
Conversation
Running `make install` does not install `p11_ver.h` header which is used by `p11_err.h`. This PR fixes it Found in Homebrew/homebrew-core#294427 Signed-off-by: botantony <antonsm21@gmail.com>
Member
|
" Is it possible that we never executed |
Collaborator
|
This patch installs Without it, compiling an external application such as: #include <libp11.h>
int main(void)
{
return 0;
}against the installed headers fails with:
LGTM, approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related Issue
Issue number: N/A
Current Behavior
make installdoes not installp11_ver.hheader used byp11_err.hNew Behavior
p11_ver.his installed toincludesScope of Changes
Testing
make installworks as expected)Additional Notes
Found in Homebrew/homebrew-core#294427
License Declaration