Skip to content

fix: publish the ovos-intents corpus even when the CSV export repo fails - #704

Draft
openvoiceos-bot wants to merge 1 commit into
devfrom
fix/publish-corpus-independently
Draft

openvoiceos-bot wants to merge 1 commit into
devfrom
fix/publish-corpus-independently

Conversation

@openvoiceos-bot

Copy link
Copy Markdown
Contributor

🤖 Auto-generated by Claude Opus 5.5 (claude-opus-5-5) via Claude Code — NOT human-reviewed. Verify before acting.

What changed

publish_hf_dataset.py now publishes each Hub repo on its own. The corpus repo (OpenVoiceOS/ovos-intents) goes first, then the CSV repo. A failure on one repo does not stop the other.

Before, main() published the CSV repo first. The Hub returns 404 for OpenVoiceOS/ovos-localize-intents, so list_repo_files raised RepositoryNotFoundError. The error ended the script and OpenVoiceOS/ovos-intents was never published. The update_data.yml step is continue-on-error, so run 37849195036 read as success.

Behavior now

Case Output Exit
Repo published published <id>: N files added, M deleted 0 if all repos published
Repo fails FAILED <id>: <exception class>: <message> non-zero at the end
  • No repo is created. A missing repo is reported only.
  • Repo ids are unchanged.
  • The empty-export refusal is unchanged and still runs before any Hub call.

Evidence

Check Result
New test on dev FAILED test_missing_csv_repo_does_not_stop_the_corpus_publish (1 failed, 11 deselected)
New tests with the fix 12 passed in test_publish_hf_dataset.py
pytest -q test/ 1 failed, 582 passed; the one failure, test_locale_rules.py::TestTableIsCurrent, also fails on unmodified dev
Ruff on touched files no findings

The test raises a real huggingface_hub.errors.RepositoryNotFoundError from a patched HfApi.list_repo_files. The script was never run against the real Hub.

🤖 Generated with Claude Code

main() published the CSV repo first and let any Hub error end the script, so a
404 on the CSV repo left the ovos-intents corpus unpublished. Each repo now
publishes on its own, the corpus first. Each outcome prints one line, and the
script exits non-zero when any repo failed. No repo is created.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Back again! I've just finished another round of automated checks. 🔄

I've aggregated the results of the automated checks for this PR below.

🏷️ Release Preview

I've generated a preview of the upcoming changes. 🎬

Current: 0.1.0a27 → Next: 0.1.1a1

Signal Value
Label (none)
PR title fix: publish the ovos-intents corpus even when the CSV export repo fails
Bump build

✅ PR title follows conventional commit format.


🚀 Release Channel Compatibility

Predicted next version: 0.1.1a1

Channel Status Note Current Constraint
Stable ⚪ Not in channel -
Testing ⚪ Not in channel -
Alpha ⚪ Not in channel -

🔍 Lint

Evaluating the overall progress of your contribution. 📉

❌ ruff: issues found in 83 file(s) — see job log
✅ actionlint: 12 workflow file(s), no finding

🔨 Build Tests

Checking the alignment of our build components. 📏

Python Build Install Tests pytest
3.10 ✅ ✅ ⚠️ 1 failed, 582 passed in 8.74s
3.11 ✅ ✅ ⚠️ 1 failed, 582 passed, 2 warnings in 9.30s
3.12 ✅ ✅ ⚠️ 1 failed, 582 passed, 2 warnings in 10.13s
3.13 ✅ ✅ ⚠️ 1 failed, 582 passed, 1 warning in 8.79s
3.14 ✅ ✅ ⚠️ 1 failed, 582 passed, 1 warning in 10.87s

❌ 3.10: Install OK, tests failed
❌ 3.11: Install OK, tests failed
❌ 3.12: Install OK, tests failed
❌ 3.13: Install OK, tests failed
❌ 3.14: Install OK, tests failed
Check job logs for details.


Final report submitted. Over and out. 📻

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants