Repository navigation
fix: publish the ovos-intents corpus even when the CSV export repo fails - #704
openvoiceos-bot wants to merge 1 commit into
Conversation
main() published the CSV repo first and let any Hub error end the script, so a 404 on the CSV repo left the ovos-intents corpus unpublished. Each repo now publishes on its own, the corpus first. Each outcome prints one line, and the script exits non-zero when any repo failed. No repo is created. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Back again! I've just finished another round of automated checks. 🔄I've aggregated the results of the automated checks for this PR below. 🏷️ Release PreviewI've generated a preview of the upcoming changes. 🎬 Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
🔍 LintEvaluating the overall progress of your contribution. 📉 ❌ ruff: issues found in 83 file(s) — see job log 🔨 Build TestsChecking the alignment of our build components. 📏
❌ 3.10: Install OK, tests failed Final report submitted. Over and out. 📻 |
What changed
publish_hf_dataset.pynow publishes each Hub repo on its own. The corpus repo (OpenVoiceOS/ovos-intents) goes first, then the CSV repo. A failure on one repo does not stop the other.Before,
main()published the CSV repo first. The Hub returns 404 forOpenVoiceOS/ovos-localize-intents, solist_repo_filesraisedRepositoryNotFoundError. The error ended the script andOpenVoiceOS/ovos-intentswas never published. Theupdate_data.ymlstep iscontinue-on-error, so run 37849195036 read as success.Behavior now
published <id>: N files added, M deletedFAILED <id>: <exception class>: <message>Evidence
FAILED test_missing_csv_repo_does_not_stop_the_corpus_publish(1 failed, 11 deselected)12 passedintest_publish_hf_dataset.pypytest -q test/1 failed, 582 passed; the one failure,test_locale_rules.py::TestTableIsCurrent, also fails on unmodified devThe test raises a real
huggingface_hub.errors.RepositoryNotFoundErrorfrom a patchedHfApi.list_repo_files. The script was never run against the real Hub.🤖 Generated with Claude Code