Skip to content

fix: regenerate data/locale_rules.json from the module - #705

Draft
openvoiceos-bot wants to merge 1 commit into
devfrom
fix/regenerate-locale-rules
Draft

openvoiceos-bot wants to merge 1 commit into
devfrom
fix/regenerate-locale-rules

Conversation

@openvoiceos-bot

Copy link
Copy Markdown
Contributor

🤖 Auto-generated by Claude Opus 5.5 (claude-opus-5-5) via Claude Code — NOT human-reviewed. Verify before acting.

data/locale_rules.json is regenerated with python scripts/gen_locale_rules.py. The committed table did not match what ovos_localize.locale_rules builds, so TestTableIsCurrent::test_the_committed_table_is_what_the_module_builds failed on dev.

The data-only commit 85984fe2 (training corpora) changed the build. The Unit Tests path filter skips data paths, so the test did not run on that commit.

What changed in the table

One file changes: data/locale_rules.json (1 insertion, 19 deletions).

Key Change
fy-nl entry removed
fy rival fy-NL removed
mwl-pt entry removed
mwl rivals now [] (was ["mwl-PT"])

The bare tags fy and mwl stay in the table. The table still has 128 tags.

Evidence

Checked by the author of this PR against the code, not by a human.

Command Result
pytest -q test/unittests/test_locale_rules.py on dev 1 failed, 29 passed (data/locale_rules.json is stale)
same, after regeneration 30 passed
pytest -q test/ after regeneration 581 passed, 1 warning

The Unit Tests path filter needs data/** so that a data commit that stales this table runs the test. This PR does not change workflows.

🤖 Generated with Claude Code

The training corpora update changed what ovos_localize.locale_rules builds.
The committed table no longer matched, so TestTableIsCurrent failed.
Regenerated with scripts/gen_locale_rules.py.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Ready for review! The automated tests have finished. ✅

I've aggregated the results of the automated checks for this PR below.

🏷️ Release Preview

The release notes are being proofread by the gnomes. 🍄

Current: 0.1.0a27 → Next: 0.1.1a1

Signal Value
Label (none)
PR title fix: regenerate data/locale_rules.json from the module
Bump build

✅ PR title follows conventional commit format.


🚀 Release Channel Compatibility

Predicted next version: 0.1.1a1

Channel Status Note Current Constraint
Stable ⚪ Not in channel -
Testing ⚪ Not in channel -
Alpha ⚪ Not in channel -

Signed, sealed, and delivered by the OVOS bot. 📧

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants