Repository navigation
fix: regenerate data/locale_rules.json from the module - #705
Draft
openvoiceos-bot wants to merge 1 commit into
Draft
openvoiceos-bot wants to merge 1 commit into
openvoiceos-bot wants to merge 1 commit into
Conversation
The training corpora update changed what ovos_localize.locale_rules builds. The committed table no longer matched, so TestTableIsCurrent failed. Regenerated with scripts/gen_locale_rules.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Ready for review! The automated tests have finished. ✅I've aggregated the results of the automated checks for this PR below. 🏷️ Release PreviewThe release notes are being proofread by the gnomes. 🍄 Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
Signed, sealed, and delivered by the OVOS bot. 📧 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data/locale_rules.jsonis regenerated withpython scripts/gen_locale_rules.py. The committed table did not match whatovos_localize.locale_rulesbuilds, soTestTableIsCurrent::test_the_committed_table_is_what_the_module_buildsfailed ondev.The data-only commit
85984fe2(training corpora) changed the build. The Unit Tests path filter skips data paths, so the test did not run on that commit.What changed in the table
One file changes:
data/locale_rules.json(1 insertion, 19 deletions).fy-nlfyfy-NLremovedmwl-ptmwl[](was["mwl-PT"])The bare tags
fyandmwlstay in the table. The table still has 128 tags.Evidence
Checked by the author of this PR against the code, not by a human.
pytest -q test/unittests/test_locale_rules.pyondev1 failed, 29 passed(data/locale_rules.json is stale)30 passedpytest -q test/after regeneration581 passed, 1 warningThe Unit Tests path filter needs
data/**so that a data commit that stales this table runs the test. This PR does not change workflows.🤖 Generated with Claude Code